Clear Logs and View Logs Functionality Added #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
reviewed
Nov 8, 2024
costdev
reviewed
Nov 8, 2024
costdev
reviewed
Nov 8, 2024
costdev
reviewed
Nov 8, 2024
costdev
reviewed
Nov 8, 2024
|
Thanks, will update. I got another issue in this PR which I haven't been able to figure out. I am getting an extra line break between each log entries in the viewer and not in the log file. Can you take a look. |
costdev
reviewed
Nov 8, 2024
Review Updates
1 task
costdev
reviewed
Nov 11, 2024
Signed-off-by: Alex Sirota <[email protected]>
asirota
approved these changes
Nov 11, 2024
Closed
Use WP_Error Class for returning error conditions.
|
Lets get this merged |
Have you addressed @costdev suggestions? |
|
Yes, everything resolved |
costdev
requested changes
Nov 12, 2024
costdev
reviewed
Nov 12, 2024
Errors are shown in alert boxes instead of inside the viewer. New error states added for clear logs.
|
@costdev PR Updated. Added more error handling too. |
costdev
reviewed
Nov 13, 2024
Redundant check removed
costdev
reviewed
Nov 13, 2024
costdev
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
Clear Logs and View Logs Functionality Added
Why did it change?
Make debugging easier and provide an easier way for casual users to see whats going on
Did you fix any specific issues?
#62
CERTIFICATION
By opening this pull request, I do agree to abide by the CODE OF CONDUCT and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the ersion in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree that this code may be licensed under any license deemed appropriate by AspirePress, including but not limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my rights or my copyright to this code.